Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feat/will hacky #482

Merged
merged 9 commits into from
Sep 8, 2023
Merged

Feat/will hacky #482

merged 9 commits into from
Sep 8, 2023

Conversation

0xJepsen
Copy link
Collaborator

@0xJepsen 0xJepsen commented Sep 7, 2023

Give an overview of the tasks completed

This PR closes #415

@0xJepsen 0xJepsen linked an issue Sep 7, 2023 that may be closed by this pull request
feat: mutate PendingTransaction directly in memory to avoid custom ethers fork #415
Closed
@0xJepsen 0xJepsen marked this pull request as ready for review September 7, 2023 21:38
Autoparallel
Autoparallel requested changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@Autoparallel Autoparallel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't merge.

test result: FAILED. 13 passed; 15 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.23s

Please get these tests working first!

My apologies. I stand corrected. I was on the wrong version of the branch! This looks good.

@0xJepsen 0xJepsen merged commit 154edb3 into anthias-labs:feat(arbiter-core)/v0.5.0 Sep 8, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Autoparallel Autoparallel Autoparallel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: mutate PendingTransaction directly in memory to avoid custom ethers fork
3 participants
@0xJepsen @Autoparallel @Will-Smith11