auto run + contructor return arc #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autoparallel
requested changes
Oct 2, 2023
Alexangelj
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Is there any reason we didn't wrap it in Arc before?
Changes look good to me.
Also (for posterity) we are fixing one of the recent merges from main in this branch:
broken: https://github.com/primitivefinance/arbiter/blob/1e4988381f4050aef86fc610977990a3f630d1b3/arbiter-core/src/environment/mod.rs#L174
working: https://github.com/primitivefinance/arbiter/blob/9e26acbfb7ff95fedb8e1a212cda15302e95f506/arbiter-core/src/environment.rs#L297
Ty for fixing
Typically However, in this case there is no reason to do it otherwise. |
Autoparallel
approved these changes
Oct 2, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Closes #560
It also modifies the
RevmMiddlewareConstructor to return anArc<RevmMiddleware>To improve the ease of use a bit since i don't believe there is a time in which we don't do this.This does also have passing tests, clippy, and fmt