Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feat/alt event capture #593

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Feat/alt event capture #593

merged 5 commits into from
Oct 5, 2023

Conversation

kinrezC
Copy link
Contributor

@kinrezC kinrezC commented Oct 5, 2023

  • Improved version of the event capture
  • .add now accepts events from arbitrary contracts rather than enforcing that all events are from a ContractInstance of the same type
  • Files are tracked in a BTreeMap to avoid re-opening when new events are received in the to the stream

@kinrezC kinrezC force-pushed the feat/alt-event-capture branch from f9ebd13 to f9c06cc Compare October 5, 2023 19:21
Autoparallel
Autoparallel approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Glad we got this going!

0xJepsen
0xJepsen approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good guys :)

@0xJepsen 0xJepsen merged commit 12c0356 into arbiter/version Oct 5, 2023
@0xJepsen 0xJepsen deleted the feat/alt-event-capture branch October 10, 2023 18:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Autoparallel Autoparallel Autoparallel approved these changes

@0xJepsen 0xJepsen 0xJepsen approved these changes

@Alexangelj Alexangelj Awaiting requested review from Alexangelj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kinrezC @Autoparallel @0xJepsen