WIP implementation of standard API functions #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davidanthoff Questions:
compute_scc
for a year not in the model's time index? the index is 2005:10:2595. Currently if they callcompute_scc(year=2020)
this will error and say they need to provide a valid year. Do we want to implement interpolation so that if they request a 2020 SCC value, it would interpolate between a 2015 SCC value and a 2025 SCC value? this would cause problems for thecompute_scc_mm
function since more than one marginalmodel is used.prtp
and constant discounting is used.And I still need to update the README