Fix scc bug #31
Merged
Fix scc bug #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
======================================
Coverage 88.7% 88.7%
======================================
Files 12 12
Lines 248 248
======================================
Hits 220 220
Misses 28 28
Continue to review full report at Codecov.
|
|
Can we add a test that makes sure this doesn't happen again? |
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm really surprised we didn't notice this sooner, but for a while our
compute_sccfunction has been returning completely incorrect numbers because of this (it was returning -$0.027 instead of $37 for year=2015, prtp-0.03, eta=0).For reference, I think it was this commit a while ago that broke it: 6cf264d