Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Undo history for creating and deleting scripts #75

Merged
merged 34 commits into from
Apr 27, 2023
Merged

Undo history for creating and deleting scripts #75

merged 34 commits into from
Apr 27, 2023

Conversation

anthonyec
Copy link
Owner

@anthonyec anthonyec commented Apr 26, 2023

Changes

  • Add undo system that stores closures for undo steps. Might be better to use Redux but this works ok for now.
  • Add ability to show toast messages
  • Create useBrowserBookmarks hook for interacting with chrome.bookmarks. This is different to how it was done, using actions and dependency injection. It's easier doing it this way, but I will see how it goes.
  • Hard code popup home screen width because toast will change it willy nilly

Notes

  • Holding down Command + Z to undo can be slow. This is because I don't properly queue the undos, they uses promises and I keep a reference to a bool to know when each undo is being processed. Would be nice to fix this so it's super fast

@anthonyec anthonyec marked this pull request as ready for review April 26, 2023 14:14
@anthonyec anthonyec force-pushed the delete-undo branch 2 times, most recently from 1a24669 to 368686c Compare April 26, 2023 17:41
@anthonyec anthonyec merged commit f61ceed into main Apr 27, 2023
@anthonyec anthonyec deleted the delete-undo branch April 27, 2023 07:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant