Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add stop/interrupt capability #174

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Add stop/interrupt capability #174

merged 2 commits into from
Nov 22, 2024

Conversation

x5a
Copy link
Collaborator

@x5a x5a commented Nov 21, 2024

  • unhide the ability to message the model while it's responding
  • add CSS styling to the stop button to highlight it in red
  • Remove the "Running agent" spinner - unfortunately it doesn't play very nice with the way stop button is implemented
  • Add message annotation/healing in maybe_add_interruption_blocks

ItsBarryZ
ItsBarryZ reviewed Nov 21, 2024
View reviewed changes
computer-use-demo/computer_use_demo/streamlit.py
@@ -195,7 +205,10 @@ def _reset_api_provider():
st.session_state.messages.append(
{
"role": Sender.USER,
"content": [BetaTextBlockParam(type="text", text=new_message)],
"content": [
*maybe_add_interruption_blocks(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceee lol

@x5a x5a requested a review from ItsBarryZ November 21, 2024 19:45
@x5a x5a enabled auto-merge (squash) November 21, 2024 19:46
@x5a x5a requested a review from zckly November 22, 2024 18:06
ItsBarryZ
ItsBarryZ approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@ItsBarryZ ItsBarryZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I spam the "stop" out of frustration the demo might still break, otherwise this function is workign quite well in my testing!

@x5a x5a merged commit 0cf556e into main Nov 22, 2024
6 checks passed
@x5a x5a deleted the zak/add-stop-and-interrupt branch November 22, 2024 19:02
siddicky pushed a commit to siddicky/kali_computer_use that referenced this pull request Nov 24, 2024
@x5a @siddicky
Add stop/interrupt capability (anthropics#174)
c8c8a98 
* add stop/interrupt capability

* correctly update session_state.tools
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ItsBarryZ ItsBarryZ ItsBarryZ approved these changes

@nsmccandlish nsmccandlish Awaiting requested review from nsmccandlish

@zckly zckly Awaiting requested review from zckly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@x5a @ItsBarryZ