-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
(fix): shortest fails when dotenv is not present #376
base: main
Are you sure you want to change the base?
Conversation
…OUND Co-Authored-By: Razvan Marescu <razvan@marescu.net>
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
🤖 Devin AI EngineerOriginal prompt from Razvan:
I'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
@@ -111,7 +111,7 @@ export const getInstallCmd = async () => { | |||
const command = resolveCommand( | |||
packageManager.agent, | |||
packageManager.agent === "yarn" ? "add" : "install", | |||
["@antiwork/shortest", "--save-dev"], | |||
["@antiwork/shortest", "dotenv", "--save-dev"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dotenv
is used internally by shortest
. Why adding it here?
While dotenv is used internally by shortest, it's listed as a peerDependency in package.json, which means it's expected to be installed by the user rather than being bundled with the package. However, it wasn't being installed during initialization, causing the error reported in issue #371. Adding it to the installation list ensures that users can run the CLI without encountering the ERR_MODULE_NOT_FOUND error. |
Fixes #371 - Adds dotenv to the list of packages installed during initialization to prevent the ERR_MODULE_NOT_FOUND error when running the shortest CLI for the first time after initialization.
Link to Devin run: https://app.devin.ai/sessions/633319e29cf746c2a3f68c1e785f669d
Requested by: louismorgner