Updated favicon check to only reject for the root domain

antoniomika · May 23, 2020 · af01eee · af01eee
1 parent ad7acfc
commit af01eee
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/httpmuxer/httpmuxer.go b/httpmuxer/httpmuxer.go
@@ -100,15 +100,15 @@ func Start(state *utils.State) {
 
 		return logLine
 	}), gin.Recovery(), func(c *gin.Context) {
+		hostname := strings.Split(c.Request.Host, ":")[0]
+		hostIsRoot := hostname == viper.GetString("domain")
+
 		// Return a 404 for the favicon.
-		if strings.HasPrefix(c.Request.URL.Path, "/favicon.ico") {
+		if hostIsRoot && strings.HasPrefix(c.Request.URL.Path, "/favicon.ico") {
 			c.AbortWithStatus(http.StatusNotFound)
 			return
 		}
 
-		hostname := strings.Split(c.Request.Host, ":")[0]
-		hostIsRoot := hostname == viper.GetString("domain")
-
 		if (viper.GetBool("admin-console") || viper.GetBool("service-console")) && strings.HasPrefix(c.Request.URL.Path, "/_sish/") {
 			state.Console.HandleRequest(hostname, hostIsRoot, c)
 			return