Add more validation of IPPool CRD #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianjuns
force-pushed
the
ipversion-check
branch
from
d9e3c60
to
d35af17
Compare
Codecov Report
@@ Coverage Diff @@
## main #3570 +/- ##
==========================================
- Coverage 63.94% 58.10% -5.85%
==========================================
Files 278 278
Lines 27838 27846 +8
==========================================
- Hits 17802 16180 -1622
- Misses 8110 9877 +1767
+ Partials 1926 1789 -137
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gran-vmv
reviewed
Apr 1, 2022
pkg/controller/ipam/validate.go
Outdated
| return false, fmt.Sprintf( | ||
| "Range is invalid. IP version of range %s-%s differs from Pool IP version", r.Start, r.End) | ||
| } | ||
|
|
Validate IP version and prefix length fields. Signed-off-by: Jianjun Shen <shenj@vmware.com>
jianjuns
force-pushed
the
ipversion-check
branch
from
d35af17
to
1808fe8
Compare
tnqn
reviewed
Apr 1, 2022
| @@ -152,7 +176,7 @@ func TestEgressControllerValidateExternalIPPool(t *testing.T) { | |||
| }, | |||
| SubnetInfo: crdv1alpha2.SubnetInfo{ | |||
| Gateway: "10:2400::01", | |||
| PrefixLength: 64, | |||
There was a problem hiding this comment.
why changing this? the new prefix /24 seems more unrealistic in ipv6.
There was a problem hiding this comment.
I added a check to prefix length must <32 for IPv4, so this case will fail for that reason (which is covered by a earlier test case already) if the length is still 64.
|
/test-all |
tnqn
approved these changes
Apr 1, 2022
| @@ -152,7 +176,7 @@ func TestEgressControllerValidateExternalIPPool(t *testing.T) { | |||
| }, | |||
| SubnetInfo: crdv1alpha2.SubnetInfo{ | |||
| Gateway: "10:2400::01", | |||
| PrefixLength: 64, | |||
|
/test-flexible-ipam-e2e |
GraysonWu
pushed a commit
to GraysonWu/antrea
that referenced
this pull request
Apr 6, 2022
Validate IP version and prefix length fields. Signed-off-by: Jianjun Shen <shenj@vmware.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate IP version and prefix length fields.
Signed-off-by: Jianjun Shen shenj@vmware.com