Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Automated cherry pick of #4160: Avoid redundant Openflow messages when syncing an updated #4164

Conversation

hongliangl
Copy link
Contributor

Cherry pick of #4160 on release-1.5.

#4160: Avoid redundant Openflow messages when syncing an updated

For details on the cherry pick process, see the cherry pick requests page.

Fix antrea-io#4159

This PR fix the issue by appending buckets directly in `Done()` in
pkg/ovs/openflow/ofctrl_group.go instead of calling `AddBuckets` method
of `Group` defined in the ofnet which sends an Openflow message to install
the group.

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
@hongliangl hongliangl added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Aug 29, 2022
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #4164 (fce3e5f) into release-1.5 (6feef90) will decrease coverage by 3.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.5    #4164      +/-   ##
===============================================
- Coverage        60.76%   57.72%   -3.04%     
===============================================
  Files              333      333              
  Lines            28574    28574              
===============================================
- Hits             17363    16495     -868     
- Misses            9294    10264     +970     
+ Partials          1917     1815     -102     
Flag Coverage Δ
kind-e2e-tests 45.03% <100.00%> (-4.78%) ⬇️
unit-tests 41.43% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/ovs/openflow/ofctrl_group.go 38.09% <100.00%> (ø)
...g/agent/apiserver/handlers/featuregates/handler.go 0.00% <0.00%> (-82.36%) ⬇️
pkg/controller/egress/store/egressgroup.go 0.00% <0.00%> (-59.73%) ⬇️
...kg/apiserver/registry/system/supportbundle/rest.go 19.54% <0.00%> (-55.18%) ⬇️
pkg/controller/types/group.go 0.00% <0.00%> (-53.85%) ⬇️
pkg/support/dump_others.go 0.00% <0.00%> (-51.73%) ⬇️
pkg/support/dump.go 8.33% <0.00%> (-48.34%) ⬇️
...egator/apiserver/handlers/recordmetrics/handler.go 0.00% <0.00%> (-44.45%) ⬇️
...g/agent/apiserver/handlers/addressgroup/handler.go 0.00% <0.00%> (-40.00%) ⬇️
...agent/apiserver/handlers/appliedtogroup/handler.go 0.00% <0.00%> (-40.00%) ⬇️
... and 41 more

@tnqn
Copy link
Member

tnqn commented Aug 30, 2022

/skip-all

@tnqn tnqn merged commit 0329dcb into antrea-io:release-1.5 Aug 30, 2022
@hongliangl hongliangl deleted the automated-cherry-pick-of-#4160-upstream-release-1.5 branch October 25, 2023 00:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants