Bugfix: Remove multicast group from cache when group is uninstalled #4176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4176 +/- ##
==========================================
+ Coverage 58.35% 58.60% +0.25%
==========================================
Files 374 374
Lines 53893 54085 +192
==========================================
+ Hits 31447 31695 +248
+ Misses 20069 20006 -63
- Partials 2377 2384 +7
*This pull request uses carry forward flags. Click here to find out more.
|
hongliangl
reviewed
Aug 30, 2022
| @@ -58,7 +58,7 @@ function generate_mocks { | |||
| "pkg/controller/querier ControllerQuerier testing" | |||
| "pkg/flowaggregator/exporter Interface testing" | |||
| "pkg/ipfix IPFIXExportingProcess,IPFIXRegistry,IPFIXCollectingProcess,IPFIXAggregationProcess testing" | |||
| "pkg/ovs/openflow Bridge,Table,Flow,Action,CTAction,FlowBuilder testing" | |||
| "pkg/ovs/openflow Bridge,Table,Flow,Action,CTAction,FlowBuilder,Group,BucketBuilder testing" | |||
There was a problem hiding this comment.
Any new auto-generated code by this udpate?
There was a problem hiding this comment.
Yes, with this change we could use gomock on Group and BucketBuilder in unit test.
wenyingd
force-pushed
the
bugfix_uninstallgroup
branch
from
fba5b89
to
9204af8
Compare
wenyingd
force-pushed
the
bugfix_uninstallgroup
branch
from
9204af8
to
b04253d
Compare
|
/test-all |
|
/test-e2e |
|
/test-multicast-e2e |
hongliangl
previously approved these changes
Aug 31, 2022
|
/test-multicast-e2e |
|
/test-multicluster-e2e |
wenyingd
changed the title
tnqn
reviewed
Sep 5, 2022
tnqn
added
action/backport
An issue exists in the code when calling UninstallGroups in multicast feature, that the group entry in the cache is not removed. This is because the existing code only remove group in featureService cache. To resolve the issue, rename the existing API UninstallGroup as UninstallServiceGroup, and add a new API UninstallMulticastGroup to delete multicast related groups. The new API also removes the group entry in the cache. Signed-off-by: wenyingd <wenyingd@vmware.com>
wenyingd
force-pushed
the
bugfix_uninstallgroup
branch
from
b04253d
to
d216562
Compare
|
/test-all |
1 similar comment
|
/test-all |
|
/test-all |
This was referenced Sep 6, 2022
Merged
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
…ntrea-io#4176) An issue exists in the code when calling UninstallGroups in multicast feature, that the group entry in the cache is not removed. This is because the existing code only remove group in featureService cache. To resolve the issue, rename the existing API UninstallGroup as UninstallServiceGroup, and add a new API UninstallMulticastGroup to delete multicast related groups. The new API also removes the group entry in the cache. Signed-off-by: wenyingd <wenyingd@vmware.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue exists in the code when calling UninstallGroups in multicast
feature, that the group entry in the cache is not removed. This is
because the existing code only remove group in featureService cache.
To resolve the issue, rename the existing API UninstallGroup as
UninstallServiceGroup, and add a new API UninstallMulticastGroup to
delete multicast related groups. The new API also removes the group
entry in the cache.
Fixes #4175
Signed-off-by: wenyingd wenyingd@vmware.com