Fix EndpointSlice API availablility check #4852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API resource name is plural. The incorrect check caused AntreaProxy to always fall back to the Endpoints API. Signed-off-by: Quan Tian <qtian@vmware.com>
tnqn
added
action/backport
hongliangl
approved these changes
Apr 12, 2023
tnqn
commented
Apr 12, 2023
| @@ -1165,7 +1165,7 @@ func endpointSliceAPIAvailable(k8sClient clientset.Interface) (bool, error) { | |||
| return false, fmt.Errorf("error getting server resources for GroupVersion %s: %v", discovery.SchemeGroupVersion.String(), err) | |||
| } | |||
| for _, resource := range resources.APIResources { | |||
| if resource.Name == "endpointslice" { | |||
There was a problem hiding this comment.
I don't remember why I used singular name for this and if I tested it with a cluster with available EndpointSlice API. Anyway change to match Kind which is more visible in API response.
antoninbas
approved these changes
Apr 12, 2023
|
/test-e2e |
This was referenced Apr 13, 2023
jainpulkit22
pushed a commit
to urharshitha/antrea
that referenced
this pull request
Apr 28, 2023
The API resource name is plural. The incorrect check caused AntreaProxy to always fall back to the Endpoints API. Signed-off-by: Quan Tian <qtian@vmware.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API resource name is plural. The incorrect check caused AntreaProxy to always fall back to the Endpoints API.