Add kubeAPIServerOverride option to antrea-controller #5056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luolanzone
reviewed
May 31, 2023
| // It is typically used when kube-proxy is not deployed (substituted by AntreaProxy) and kube-controller-manager | ||
| // does not run NodeIPAMController (substituted by Antrea NodeIPAM). | ||
| // Defaults to "". It must be a host string, a host:port pair, or a URL to the base of the apiserver. | ||
| KubeAPIServerOverride string `yaml:"kubeAPIServerOverride,omitempty"` |
There was a problem hiding this comment.
Should we reflect this change in a doc?
There was a problem hiding this comment.
updated docs/antrea-ipam.md
luolanzone
added
the
action/release-note
luolanzone
previously approved these changes
May 31, 2023
antoninbas
reviewed
May 31, 2023
.github/workflows/kind.yml
Outdated
| ANTREA_LOG_DIR=$PWD/log ANTREA_COV_DIR=$PWD/test-e2e-encap-all-features-enabled-coverage ./ci/kind/test-e2e-kind.sh \ | ||
| --encap-mode encap \ | ||
| --coverage \ | ||
| --feature-gates AllAlpha=true,AllBeta=true,FlowExporter=false \ |
There was a problem hiding this comment.
nit: we can remove FlowExporter=false now that #5021 has been merged
(and remove the comment above)
| @@ -239,6 +239,7 @@ nodePortLocal: | |||
| {{- end }} | |||
|
|
|||
| # Provide the address of Kubernetes apiserver, to override any value provided in kubeconfig or InClusterConfig. | |||
| # It is typically used when kube-proxy is not deployed (substituted by AntreaProxy). | |||
There was a problem hiding this comment.
s/substituted by AntreaProxy/replaced by AntreaProxy
To override the address of Kubernetes apiserver for antrea-controller, the option, kubeAPIServerOverride, is added to antrea-controller.conf. It's typically used when kube-proxy is not deployed (substituted by AntreaProxy) and kube-controller-manager does not run NodeIPAMController (substituted by Antrea NodeIPAM). Signed-off-by: Quan Tian <qtian@vmware.com>
|
/skip-all |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To override the address of Kubernetes apiserver for antrea-controller, the option, kubeAPIServerOverride, is added to antrea-controller.conf. It's typically used when kube-proxy is not deployed (substituted by AntreaProxy) and kube-controller-manager does not run NodeIPAMController (substituted by Antrea NodeIPAM).
Fixes #5022