Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Automated cherry pick of #6050: Fix wrong TCP flags validation (#6050) #6057

Conversation

gran-vmv
Copy link
Contributor

@gran-vmv gran-vmv commented Mar 4, 2024

Cherry pick of #6050 on release-1.13.

#6050: Fix wrong TCP flags validation (#6050)

For details on the cherry pick process, see the cherry pick requests page.

@gran-vmv gran-vmv added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Mar 4, 2024
@gran-vmv gran-vmv self-assigned this Mar 4, 2024
@gran-vmv gran-vmv requested a review from tnqn March 4, 2024 07:19
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Mar 5, 2024

/skip-all

@tnqn
Copy link
Member

tnqn commented Mar 5, 2024

@gran-vmv The username you used in gitconfig is "Ran Gu" while the username you used in "Signed-off-by" is "gran", did you sign off the commit manually, as opposed to using -s? The difference caused DCO check to not pass for backport PRs (I don't know why the original PR didn't fail). Please amend these PRs to fix the check, and you should perhaps starting using -s to sign off commits in the future to avoid the inconvenience. Note that "Signed-off-by" normally expects full name instead of an ID.

Signed-off-by: gran <gran@vmware.com>
@gran-vmv gran-vmv force-pushed the automated-cherry-pick-of-#6050-upstream-release-1.13 branch from 89bf197 to bdf9452 Compare March 5, 2024 03:16
@gran-vmv
Copy link
Contributor Author

gran-vmv commented Mar 5, 2024

@gran-vmv The username you used in gitconfig is "Ran Gu" while the username you used in "Signed-off-by" is "gran", did you sign off the commit manually, as opposed to using -s? The difference caused DCO check to not pass for backport PRs (I don't know why the original PR didn't fail). Please amend these PRs to fix the check, and you should perhaps starting using -s to sign off commits in the future to avoid the inconvenience. Note that "Signed-off-by" normally expects full name instead of an ID.

I generated these cherry-picks on another machine, and the gitconfig is not fully configured on that machine, thus we get DCO error.
Fixed the gitconfig and sign this commit again for these 3 PRs.

@gran-vmv
Copy link
Contributor Author

gran-vmv commented Mar 5, 2024

Using "Signed-off-by: gran" as the commit in master has this.

@tnqn
Copy link
Member

tnqn commented Mar 5, 2024

/skip-all

@tnqn tnqn merged commit 25bf7cb into antrea-io:release-1.13 Mar 5, 2024
47 of 52 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants