Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[RA1]: Adding Piccolo theme #3364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[RA1]: Adding Piccolo theme #3364

wants to merge 1 commit into from

Conversation

CsatariGergely
Copy link
Collaborator

No description provided.

@CsatariGergely
[RA1]: Adding Piccolo theme
9acea5f 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely CsatariGergely requested a review from collivier as a code owner May 10, 2023 00:51
@bfcohen
Copy link
Collaborator

bfcohen commented Jul 18, 2023

Approved

@bfcohen bfcohen assigned bfcohen and unassigned bfcohen Jul 18, 2023
@CsatariGergely CsatariGergely requested a review from bfcohen July 25, 2023 14:18
@CsatariGergely
Copy link
Collaborator Author

Approved

Thanks, please approve also in the " Files changed" tab, so GitHub can recognise it.

@bfcohen
Copy link
Collaborator

bfcohen commented Aug 1, 2023

I approve this.

@bfcohen bfcohen closed this Aug 1, 2023
bfcohen
bfcohen reviewed Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@bfcohen bfcohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK with me.

@CsatariGergely CsatariGergely reopened this Aug 1, 2023
bfcohen
bfcohen approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@bfcohen bfcohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve these changes.

collivier
collivier requested changes Oct 1, 2023
View reviewed changes
Copy link
Collaborator

@collivier collivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of RTD forcing the use of .readthedocs.yaml, we don't have another choice than splitting the git repository per stream. This PR must be applied on next RM's git repository and not here.

Everything is already ready on my own repositories but sadly I don't have the rights needed on anuket-project organization. Please give me them to complete the migration.

Be free to ask for any detail about the migration during a Weekly Technical meeting.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@collivier collivier collivier requested changes

@ildikov ildikov ildikov approved these changes

@gkunz gkunz gkunz approved these changes

@bfcohen bfcohen bfcohen approved these changes

@steelescotr steelescotr steelescotr approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CsatariGergely @bfcohen @ildikov @collivier @gkunz @steelescotr