Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Use consatnts.rs instead of dotenv #8

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Conversation

priyansh17
Copy link
Collaborator

What is this PR for?

This PR is to fix the issues caused by dotenv module.
I have introduced a custom map of resources named constants instead.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

None

How should this be tested?

Build a package release and test on windows/ linux.

Screenshots (if appropriate)

Questions:

  • - There is breaking changes for older versions.
  • - It needs documentation.

Copy link
Owner

@anusikh anusikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anusikh anusikh merged commit 5ab6977 into anusikh:main Mar 6, 2024
4 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants