How does the margin_top argument of PageBreak work?

[stenci]

I am building a multipage PDF by adding a few pages separated by PageBreak. Everything seems to be working well. I don't really need an answer here for completing my job, but since I don't understand what an undocumented and apparently useless, but required parameter does, I thought I would bring it up here.

I tried using both 1 and 500 integers and '1px' and '500px' strings with the following code, but the result doesn't change:

class PrintPDF(PrintPDFTemplate):
  def __init__(self, project_number, release_number, truck_number, **properties):
    self.release = Release(project_number, release_number)
    self.truck = self.release.trucks[truck_number - 1]

    self.init_components(**properties)

    self.add_component(TruckPDF(self.truck))
    self.add_component(PageBreak('500px'))
    self.add_component(TruckPDF(self.truck))
    self.add_component(PageBreak('1px'))
    self.add_component(TruckPDF(self.truck))

I wasn't expecting it to require any parameter, but since one is required, I was expecting to see some difference in the top margin. instead it doesn't make any difference.

This is the result on the browser:

and this is the result on the PDF"

[hugetim]

@stenci, thanks for reporting this. Here's a way to say the same thing that I would find more pleasant to read, for next time:

The margin_top property of PageBreak doesn't have the effect that I expected. Also, please make it an optional argument.

[stenci]

@hugetim
I apologize if my post sounded offensive or negative in any way. It was not my intention at all.

I just re-read my post and it didn't look harsh, offensive or rantish in any way. At least to me, I will blame it on English not being my first language.

I had a question, I investigated a little trying to understand, I failed, so I asked the question documenting my investigation.

Here is my thought process while writing it:

• I had a question and I opened an issue with the question as subject
• I said "I don't really need an answer" meaning I'm ok if you don't want to waste your time addressing it
• "I don't understand" meaning it's ME not understanding
• "apparently useless" I intentionally put apparently right after don't understand, again to blame it on myself
• "I thought I would bring it up here" again meaning it's not important, I just want to share my thought in case you find it useful
• I added snapshots to show what I was looking at, to make it easier for you to tell me if I was looking in the wrong place

It looks like I tried to be nice too hard and something went wrong.
Again, I apologize.

[s-cork]

It has no effect in the designer.
In some cases there is unnecessary space at the top of the generated page.
(Or at least that's what I found - but that can be browser/os specific)
so setting the margin-top to be negative might help with the final pdf.

However it clearly wasn't working and the pdf you've shown works as I'd expect.

Anyway I've fixed this in #137 by making it optional.
And documenting it.

[hugetim]

Sounds like my mistake, then, @stenci. Sorry about that. I think I just misinterpreted your tone, and I'm pretty new at this. It was indeed a really informative report. (I wouldn't be able to explain such a thing at all in a second language, myself.)

…

--- typed with thumbs

On Fri, Sep 10, 2021, 8:51 PM stenci ***@***.***> wrote: @hugetim <https://github.com/hugetim> I apologize if my post sounded offensive or negative in any way. It was not my intention at all. I just re-read my post and it didn't look harsh, offensive or rantish in any way. At least to me, I will blame it on English not being my first language. I had a question, I investigated a little trying to understand, I failed, so I asked the question documenting my investigation. Here is my thought process while writing it: - I had a question and I opened an issue with the question as subject - I said "I don't really need an answer" meaning I'm ok if you don't want to waste your time addressing it - "I don't understand" meaning it's ME not understanding - "apparently useless" I intentionally put apparently right after don't understand, again to blame it on myself - "I thought I would bring it up here" again meaning it's not important, I just want to share my thought in case you find it useful - I added snapshots to show what I was looking at, to make it easier for you to tell me if I was looking in the wrong place It looks like I tried to be nice too hard and something went wrong. Again, I apologize. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#136 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB63GLBDOCBGAMO4BT4TY63UBKY3FANCNFSM5D2C2NAA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.