Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add border property to PageBreak #139

Merged
merged 3 commits into from
Sep 16, 2021
Merged

Conversation

stenci
Copy link
Contributor

@stenci stenci commented Sep 14, 2021

Sometimes the PDF contains horizontal grey lines, so the PageBreak lines get confused with the ones that are part of the PDF.

This new border property allows to change the default style to something different form the rest of the PDF. It has no effect on the generated PDF.

In one of my PDFs I'm using:

self.add_component(TruckPDF(self.truck))
for crate in self.truck.crates:
  self.add_component(PageBreak(border='1px dashed red'))
  self.add_component(CratePDF(crate))

close #142

Copy link
Collaborator

@s-cork s-cork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (looks good to me) - some code suggestions.

Edit - and can we update CHANGELOG.md?

client_code/PageBreak/__init__.py Outdated Show resolved Hide resolved
docs/guides/components/page_break.rst Outdated Show resolved Hide resolved
docs/guides/components/page_break.rst Outdated Show resolved Hide resolved
@s-cork
Copy link
Collaborator

s-cork commented Sep 16, 2021

@stenci - are you happy to resolve the suggestions above with another commit?
(I'm also happy to resolve them).

@s-cork
Copy link
Collaborator

s-cork commented Sep 16, 2021

Perfect - thanks for fixing #142 - merging

@s-cork s-cork merged commit a8ceca0 into anvilistas:main Sep 16, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML issues
2 participants