Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Auto Refreshing Item #39

Merged
merged 5 commits into from
Mar 27, 2021
Merged

Auto Refreshing Item #39

merged 5 commits into from
Mar 27, 2021

Conversation

meatballs
Copy link
Member

@meatballs meatballs commented Mar 25, 2021

  • Implementation Code
  • Documentation
  • Example use in demo
  • override dict.update

@s-cork
Copy link
Collaborator

s-cork commented Mar 25, 2021

Not necessarily part of this pr but we could make utils a lazy module and use the __dir__ to expose the available attributes. I think meredydd added the feature so that a module with a __dir__ comes up in the autocomplete

@s-cork
Copy link
Collaborator

s-cork commented Mar 25, 2021

I don't know how important it is but overriding __setitem__ isn't enough to trigger a refresh if you use dict.update. Might be a nice bonus.

@meatballs meatballs force-pushed the 38-auto-refreshing-item branch from d718c32 to f344fdf Compare March 26, 2021 10:30
@meatballs
Copy link
Member Author

Not necessarily part of this pr but we could make utils a lazy module and use the __dir__ to expose the available attributes. I think meredydd added the feature so that a module with a __dir__ comes up in the autocomplete

I think this one ought to be a separate issue and pr.

@meatballs meatballs marked this pull request as ready for review March 26, 2021 16:06
@meatballs meatballs requested a review from s-cork March 27, 2021 09:44
Copy link
Collaborator

@s-cork s-cork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@s-cork s-cork merged commit 8f49e52 into main Mar 27, 2021
@s-cork s-cork deleted the 38-auto-refreshing-item branch March 27, 2021 10:25
@meatballs
Copy link
Member Author

I'll put a new release together some time today.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants