Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

multi select component #44

Merged
merged 16 commits into from
May 20, 2021
Merged

multi select component #44

merged 16 commits into from
May 20, 2021

Conversation

s-cork
Copy link
Collaborator

@s-cork s-cork commented Apr 19, 2021

  • multi select functionality
  • demo
  • docs

@s-cork
Copy link
Collaborator Author

s-cork commented Apr 19, 2021

@meatballs - do you think it's worth refactoring the add_script into its own separate util function?

Any initial thoughts before I add the docs let me know.

@meatballs
Copy link
Member

I'll try to have a look at this tomorrow

@meatballs
Copy link
Member

Sorry it took me a while, but I've tried that out now and it's looking great. Nice work!

@s-cork
Copy link
Collaborator Author

s-cork commented Apr 22, 2021

Never any rush! great I'll have a go at documentation. And will mark it as ready for review when that's done.
Will also add the change event in the demo

@s-cork
Copy link
Collaborator Author

s-cork commented Apr 26, 2021

I think this might be a better library to use https://developer.snapappointments.com/bootstrap-select/examples/

@meatballs
Copy link
Member

I think this might be a better library to use https://developer.snapappointments.com/bootstrap-select/examples/

Yeah, that does look nice.

@s-cork
Copy link
Collaborator Author

s-cork commented Apr 26, 2021

And it still supports bootstrap 3 which is a win

@s-cork s-cork force-pushed the stu-dev/multiselect branch from 3da03d5 to 9d704ca Compare May 16, 2021 14:26
@s-cork s-cork force-pushed the stu-dev/multiselect branch from 9d704ca to 00361cb Compare May 16, 2021 14:28
@s-cork s-cork marked this pull request as ready for review May 18, 2021 15:53
@s-cork s-cork marked this pull request as draft May 18, 2021 15:59
@s-cork
Copy link
Collaborator Author

s-cork commented May 18, 2021

There's a small bug - I think it conflicts with anvil's version so just need to check it works properly

@s-cork s-cork marked this pull request as ready for review May 19, 2021 01:32
@s-cork s-cork requested a review from meatballs May 19, 2021 14:17
Copy link
Member

@meatballs meatballs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor things from me. Looking good!

client_code/MultiSelectDropDown/__init__.py Outdated Show resolved Hide resolved
client_code/MultiSelectDropDown/__init__.py Outdated Show resolved Hide resolved
@s-cork s-cork force-pushed the stu-dev/multiselect branch from f42a118 to 86f5adb Compare May 19, 2021 16:00
@meatballs meatballs merged commit a0fc92d into main May 20, 2021
@meatballs meatballs deleted the stu-dev/multiselect branch May 20, 2021 08:48
@meatballs meatballs linked an issue May 20, 2021 that may be closed by this pull request
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiSelect dropdown
2 participants