augment: remove javascript hacks #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
s-cork
force-pushed
the
augment-python
branch
from
5ca23aa to
7e6969b
Compare
|
Do we have any other breaking changes in mind? I'd like to work on persistence and that might involve some deprecation, but I just haven't found the time. |
|
there's a board here: things that have warnings on that can be removed in a bumped version |
|
I think this is good as is. It adds a warning like the others. At some point, we can make good on those warnings, remove the features and bump the major version |
s-cork
force-pushed
the
augment-python
branch
from
7e6969b to
3843d34
Compare
s-cork
force-pushed
the
augment-python
branch
from
3843d34 to
5ea320d
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
augment: remove javascript hacks
instead use class monkey patching
at least this way we don't touch the javascript internals
and deprecates trigger-writeback which can now be done natively
If we think the deprecation requires a major bump then I can remove it from this PR
Maybe it's time for a major bump 🤷