v1.18: ci: don't self-update rustup when using the rust-version script (backport of #1209) #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.18 #1215 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 827 827
Lines 225352 225352
=========================================
- Hits 184043 183997 -46
- Misses 41309 41355 +46 |
t-nelson
approved these changes
May 10, 2024
joedenis01
approved these changes
May 11, 2024
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…t (backport of anza-xyz#1209) (anza-xyz#1215) ci: don't self-update rustup when using the rust-version script (anza-xyz#1209) * ci: don't update rustup when using the rust-version script * XXX: fake updates for triggering all * Revert "XXX: fake updates for triggering all" This reverts commit b343e61. (cherry picked from commit 206a87a) Co-authored-by: Yihau Chen <yihau.chen@icloud.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
we have some issues with Windows pipelines when setting up Rust version.
context: https://discord.com/channels/428295358100013066/560503042458517505/1237118149510566011
I found an issue in rustup repo: rust-lang/rustup#3709
I think it's harmless to adopt the workaround as our standard process. (even a better idea
)
Summary of Changes
add
--no-self-updateto rust-versionthe successful build: https://github.com/anza-xyz/agave/actions/runs/8979866592/job/24662583658?pr=1209
This is an automatic backport of pull request #1209 done by [Mergify](https://mergify.com).