-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Prefer explicitly using serde_derive instead of the "derive" feature of serde #1329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just some nits to add comments about the versioning
c64d14c
to
e48189a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1329 +/- ##
=========================================
- Coverage 82.8% 82.8% -0.1%
=========================================
Files 867 867
Lines 368875 368873 -2
=========================================
- Hits 305646 305642 -4
- Misses 63229 63231 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Problem
Using the "derive" feature of serde is bad for compile times as explained here serde-rs/serde#2584
Summary of Changes