Refactor tests, add table arities #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcompton
changed the title
danielcompton
force-pushed
the
refactor-tests
branch
2 times, most recently
from
a75dfdf to
c7e546a
Compare
The new arities will use the implicit DB from the connection. - Add documentation for database priority to ns docstring - Update docstrings on functions to reference priority docs in ns docstring Arities modified on - table-drop - table-list table-create was left as I wasn't yet sure how to handle the optargs with two arities.
This change makes it easier to isolate failing tests and to create new tests. - Split the one large deftest into many smaller deftests - Add fixtures to recreate pokedex table between every test - Remove `run` and `db-run` command from core-test ns - Remove global `conn`, each test now creates its own connection
Table-list already had tests using it.
danielcompton
force-pushed
the
refactor-tests
branch
from
c7e546a to
0f685f5
Compare
danielcompton
added a commit
that referenced
this pull request
Jul 2, 2015
Refactor tests, add table arities
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it easier to isolate failing tests and to create new tests.
runanddb-runcommand from core-test nsconn, each test now creates its own connectionAdd arity for table and db operations without DB, the new arities will use the implicit DB from the connection.
Arities modified on
table-create was left as I wasn't yet sure how to handle the optargs with two arities.