Add clojure.tools.logging and logging statements #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Library users will need to provide a clojure.tools.logging compatible logger to see these logs, we don't bundle logback so we can let the user choose. Similarly, they will need to provide their own logging config, as our one is in test-resources and won't be packaged in the JAR.
danielcompton
force-pushed
the
add-logging
branch
from
082dcf9 to
43746a4
Compare
danielcompton
added a commit
that referenced
this pull request
Aug 6, 2015
Add clojure.tools.logging and logging statements
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library users will need to provide a clojure.tools.logging compatible logger to see these logs, we don't bundle logback so we can let the user choose. Similarly, they will need to provide their own logging config, as our one is in test-resources and won't be packaged in the JAR.