Add ORDER BY so test data is deterministic #32489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
xcom-endpoint-test-deterministic
branch
from
14b75f5 to
e647a1c
Compare
uranusjr
force-pushed
the
xcom-endpoint-test-deterministic
branch
from
e647a1c to
30c4112
Compare
potiuk
approved these changes
Jul 10, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main branch is failing occassionally after #32453 was merged, but the underlying issue is pretty apparently not that specific PR, but an ill-implemented test. Without adding an explicit ORDER BY clause, the order of the XCom objects is indeterministic and can cause the test to fail.
I also took the chance to rewrote the query in the test to use the new SQLAlchemy 2.0 style because why not.