-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add extra operator links for EMR Serverless #34225
Add extra operator links for EMR Serverless #34225
Conversation
- Includes Dashboard UI, S3 and CloudWatch consoles - Only shows links relevant to the job
@dacort are you still working on it? |
@eladkal Yes, let me check out the failing tests. |
@eladkal Ah yes, that's right, I was trying to figure out a better way to pass the operator in, but I think I'll just pass in the |
Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this Damon, looking good! Left some comments
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
Hey @dacort, this one looks like it was close but is getting marked as stale. Do you still have time to finish it off? |
Yes, let me try to resolve existing conflicts and get it over the finish line. :) |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! LGTM
@dacort @o-nikolas is anything else needed or can we merge this PR? |
@eladkal, the last remaining item is adding some unit testing for this code (thread here) |
ack - will see if I can get that pushed up today! |
@eladkal @o-nikolas Added some additional unit tests to cover the various cases and merge in latest main. Several of the DB tests are failing, but seem unrelated to my changes. |
Main is broken right now, you'll at least need to wait for this PR to be merged and then rebase your branch. |
Sweet, rebased and all checks have passed! |
Only one conversation left open that needs resolution and then I think we're ready to merge! |
@dacort can you rebase and resolve conflicts? I'll merge after |
@dacort static checks are failing due to adding D401 validation |
@eladkal Ah, thank you, had missed that failure reason. Will get that addressed today! |
closes: #31620
aws_conn_id
from the operator hook so the proper credentials are used^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.