-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Let auth managers provide their own API endpoints #34349
Conversation
- fix paths - add error handling to all existing endpoints
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some static failures though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd actually rather we let the auth manager provide an arbitrary blueprint so we don't force the use of connexion, but I won't stand in the way on that change.
closes #32207
I marked the existing endpoints as deprecated, but it only appears in the doc I think. IDK how to get the message across to current users so that they change the route they use, if we ever want to remove the user & role endpoints from the "main" API.