Let auth managers provide their own API endpoints #34349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vandonr-amz
requested review from
ryanahamilton,
ashb,
bbovenzi,
pierrejeambrun and
ephraimbuddy
as code owners
boring-cyborg
bot
added
area:API
vincbeck
reviewed
Sep 13, 2023
- fix paths - add error handling to all existing endpoints
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
vincbeck
reviewed
Sep 13, 2023
vincbeck
reviewed
Sep 14, 2023
vincbeck
reviewed
Sep 22, 2023
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
vincbeck
approved these changes
Sep 25, 2023
potiuk
approved these changes
Oct 16, 2023
jedcunningham
approved these changes
Oct 17, 2023
ephraimbuddy
added
the
changelog:skip
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #32207
I marked the existing endpoints as deprecated, but it only appears in the doc I think. IDK how to get the message across to current users so that they change the route they use, if we ever want to remove the user & role endpoints from the "main" API.