Add extra fields to plugins endpoint #34913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:API
ephraimbuddy
force-pushed
the
add-more-fields-to-plugin-schema
branch
from
4e689b7 to
a399c40
Compare
uranusjr
reviewed
Oct 18, 2023
|
Needs updating once this #35022 is merged |
I added three extra fields, ti_deps, timetables, and listeners which I think are worth having since they will help in visualizing if those are included in a plugin. I also found out that the UI has admin_views and menu_links which seems to come from airflow 1 but for consistency, I merged the attributes for both UI & webserver to be the same. The REST API does not have these two attributes as I feel they will soon be removed.
ephraimbuddy
force-pushed
the
add-more-fields-to-plugin-schema
branch
from
95b8b97 to
e1ca400
Compare
uranusjr
approved these changes
Oct 20, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added three extra fields, ti_deps, timetables, and listeners which I think are worth having since they will help in visualizing if those are included in a plugin.
I also found out that the UI has admin_views and menu_links which seems to come from airflow 1 but for consistency, I merged the attributes for both UI & webserver to be the same. The REST API does not have these two attributes as I feel they will soon be removed.