Add data_interval_start and data_interval_end in dagrun create API endpoint #36630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karakanb
requested review from
ryanahamilton,
ashb,
bbovenzi,
pierrejeambrun and
ephraimbuddy
as code owners
boring-cyborg
bot
added
area:API
pankajastro
reviewed
Jan 6, 2024
karakanb
force-pushed
the
main
branch
2 times, most recently
from
260fe1e to
01be3b9
Compare
uranusjr
reviewed
Jan 10, 2024
karakanb
force-pushed
the
main
branch
5 times, most recently
from
6b93bdd to
2229211
Compare
karakanb
force-pushed
the
main
branch
4 times, most recently
from
54d9dcc to
235ee98
Compare
uranusjr
reviewed
Jan 23, 2024
uranusjr
reviewed
Jan 23, 2024
uranusjr
reviewed
Jan 23, 2024
uranusjr
reviewed
Jan 23, 2024
|
Some minor suggestions, the overall logic looks good to me. Test code needs some cleanup, and a rebase is also needed. |
|
@uranusjr addressed all of them, could you please take a look? |
uranusjr
approved these changes
Jan 23, 2024
potiuk
approved these changes
Jan 26, 2024
ephraimbuddy
added
type:new-feature
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new variables in the DAGRun create API endpoint to enable creating runs that cover a specific span. This allows triggering runs that span multiple interfaces in case of backfills.