Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Create GKEStartJobOperator and KubernetesJobOperator #36847

Merged
merged 8 commits into from
Feb 15, 2024

Conversation

MaksYermak
Copy link
Contributor

In this PR I have created operators for starting Kubernetes Job in clusters(ordinary and GKE).


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you merge/rebase main?

@eladkal
Copy link
Contributor

eladkal commented Jan 17, 2024

There was a discussion about this capability in #17490

@MaksYermak MaksYermak force-pushed the gke-start-job-operator branch from ddfc58e to 93dced5 Compare January 17, 2024 16:59
@MaksYermak
Copy link
Contributor Author

Could you merge/rebase main?

Sure, I have rebased the branch.

@raphaelauv
Copy link
Contributor

👍

would be great to also add some doc there -> #36847

like KPO vs KOJ ...

@eladkal eladkal mentioned this pull request Jan 21, 2024
@MaksYermak MaksYermak force-pushed the gke-start-job-operator branch from 248f902 to a37b29d Compare January 29, 2024 13:24
@dirrao
Copy link
Contributor

dirrao commented Feb 1, 2024

👍

would be great to also add some doc there -> #36847

like KPO vs KOJ ...

Yes. It would be great to document when to prefer KJO over KPO.

@MaksYermak MaksYermak force-pushed the gke-start-job-operator branch 2 times, most recently from 7e6deac to f9dd537 Compare February 6, 2024 15:45
@MaksYermak
Copy link
Contributor Author

@dirrao @raphaelauv @hussein-awala I have updated documentation for KubernetesJobOperator. Could you review my PR one more time?

@VladaZakharova
Copy link
Contributor

Hi @eladkal !
Could you please take a look on these changes? Thanks!

@potiuk
Copy link
Member

potiuk commented Feb 15, 2024

Hey @VladaZakharova @MaksYermak - can you rebase please? Conflicts got in the way after I merged #37072

@MaksYermak MaksYermak force-pushed the gke-start-job-operator branch from f9dd537 to 8166ea9 Compare February 15, 2024 16:05
@MaksYermak
Copy link
Contributor Author

MaksYermak commented Feb 15, 2024

Hey @VladaZakharova @MaksYermak - can you rebase please? Conflicts got in the way after I merged #37072

Hi @potiuk , I have rebased the branch.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area:providers area:system-tests kind:documentation provider:cncf-kubernetes Kubernetes provider related issues provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants