Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updates to ECS Executor Docs #37125

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

o-nikolas
Copy link
Contributor

The main fixes include:

  • The python version check should not be before the image has been built
  • Doesn't tell you to switch to the directory with the dockerfile, added this note before the first build command.
  • COPY URI for S3 template, not URL
  • There were asterisks in the config at the bottom of the doc instead of underscores
  • Update region name config option (which was renamed in code, but not updated in code)

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The main fixes include:
- The python version check should not be before the image has been built
- Doesn't tell you to switch to the directory with the dockerfile, added
this note before the first build command.
- COPY URI for S3 template, not URL
- There were asterisks in the config at the bottom of the doc instead of underscores
- Update region name config option (which was renamed in code, but not updated in code)
@boring-cyborg boring-cyborg bot added area:production-image Production image improvements and fixes area:providers kind:documentation provider:amazon AWS/Amazon - related issues labels Feb 1, 2024
@o-nikolas o-nikolas changed the title Updates to ECS Docs Updates to ECS Executor Docs Feb 1, 2024
@o-nikolas o-nikolas marked this pull request as ready for review February 1, 2024 16:59
@o-nikolas o-nikolas requested a review from ferruzzi February 1, 2024 16:59
Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recently had to go through these steps to build a new test environment and these look like good clarifications to me. Thanks!

@o-nikolas o-nikolas merged commit 55cc7bd into apache:main Feb 1, 2024
55 checks passed
@o-nikolas o-nikolas deleted the onikolas/ecs_docs_fixes branch February 1, 2024 18:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area:production-image Production image improvements and fixes area:providers kind:documentation provider:amazon AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants