Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reorder OpenAPI Spec tags alphabetically #38717

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

pankajkoti
Copy link
Member

Re-order the Tags in our API Spec view to be sorted alphabetically.

This one is quick PR to fix the current order, but perhaps we could
work on adding a pre-commit to ensure this list stays sorted.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Apr 3, 2024
@pankajkoti
Copy link
Member Author

pankajkoti commented Apr 3, 2024

Before - unsorted list
Screenshot 2024-04-03 at 10 02 16 PM

After - ordered list
Screenshot 2024-04-03 at 9 54 28 PM

@pankajkoti pankajkoti requested a review from kaxil April 3, 2024 16:21
Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we should do a precommit hook to keep these sorted. Can you open a follow up PR for that?

@pankajkoti pankajkoti added the use public runners Makes sure that Public runners are used even if commiters creates the PR (useful for testing) label Apr 3, 2024
@pankajkoti pankajkoti closed this Apr 3, 2024
@pankajkoti pankajkoti reopened this Apr 3, 2024
@pankajkoti pankajkoti merged commit 9b2d7cb into apache:main Apr 3, 2024
64 of 76 checks passed
@pankajkoti pankajkoti deleted the reorder-openapi-spec-tags branch April 3, 2024 18:33
@pankajkoti pankajkoti added this to the Airflow 2.9.0 milestone Apr 4, 2024
ephraimbuddy pushed a commit that referenced this pull request Apr 4, 2024
Re-order the Tags in our API Spec view to be sorted alphabetically.

This one is quick PR to fix the current order, but perhaps we could
work on adding a pre-commit to ensure this list stays sorted.

(cherry picked from commit 9b2d7cb)
@ephraimbuddy ephraimbuddy added the type:doc-only Changelog: Doc Only label Jun 3, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area:API Airflow's REST/HTTP API type:doc-only Changelog: Doc Only use public runners Makes sure that Public runners are used even if commiters creates the PR (useful for testing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants