Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Resolve deprecation warnings in Google Kubernetes Engine system tests (#39485) #41492

Conversation

topherinternational
Copy link
Contributor

Reworks the GKE example DAGs to remove deprecation warnings, also fixes a misprint in the deprecation warning message.

related: #39485

@VladaZakharova requested to be tagged for Google provider changes

@Taragolis as issue owner

@boring-cyborg boring-cyborg bot added area:providers area:system-tests provider:cncf-kubernetes Kubernetes provider related issues provider:google Google (including GCP) related issues labels Aug 15, 2024
@@ -44,7 +44,7 @@
CLUSTER_NAME = CLUSTER_NAME_BASE if len(CLUSTER_NAME_FULL) >= 33 else CLUSTER_NAME_FULL

# [START howto_operator_gcp_gke_create_cluster_definition]
CLUSTER = {"name": CLUSTER_NAME, "initial_node_count": 1, "autopilot": {"enabled": True}}
CLUSTER = {"name": CLUSTER_NAME, "node_pools": [{"initial_node_count": 1}], "autopilot": {"enabled": True}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@topherinternational did you try to run this DAG on your Google Cloud environment?
Because I got this error when I tried to run this DAG:

[2024-08-21T12:13:25.226+0000] {taskinstance.py:3296} ERROR - Task failed with exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/google/api_core/grpc_helpers.py", line 76, in error_remapped_callable
    return callable_(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/grpc/_channel.py", line 1181, in __call__
    return _end_unary_response_blocking(state, call, False, None)
  File "/usr/local/lib/python3.8/site-packages/grpc/_channel.py", line 1006, in _end_unary_response_blocking
    raise _InactiveRpcError(state)  # pytype: disable=not-instantiable
grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.INVALID_ARGUMENT
	details = "Node_pool.name must be specified."
	debug_error_string = "UNKNOWN:Error received from peer ipv4:66.102.1.95:443 {created_time:"2024-08-21T12:13:25.224438184+00:00", grpc_status:3, grpc_message:"Node_pool.name must be specified."}"
>

in my opinion it means that this Cluster configuration is incorrect

@eladkal
Copy link
Contributor

eladkal commented Sep 20, 2024

@topherinternational @VladaZakharova what is the status of this PR?

Copy link

github-actions bot commented Nov 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Nov 5, 2024
@VladaZakharova
Copy link
Contributor

@topherinternational @VladaZakharova what is the status of this PR?

Hi! Waiting for @topherinternational to answer Max's question, since we think the system test will not work correctly with such configuration

@github-actions github-actions bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Nov 6, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 21, 2024
@github-actions github-actions bot closed this Dec 26, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area:providers area:system-tests provider:cncf-kubernetes Kubernetes provider related issues provider:google Google (including GCP) related issues stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants