-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add note about using dag_run.conf in BashOperator #9143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
force-pushed
the
update-example-trigger-dag
branch
from
June 4, 2020 14:43
08d2452
to
d10f545
Compare
kaxil
approved these changes
Jun 4, 2020
kaxil
reviewed
Jun 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc building error
==================== Error 2 ====================
WARNING: Could not lex literal_block as "python". Highlighting skipped.
File path: /opt/airflow/docs/howto/operator/bash.rst (67)
63 |
64 | Instead, you should pass this via the ``env`` kwarg and use double-quotes
65 | inside the bash_command, as below:
66 |
67 | .. code-block:: python
68 |
69 | bash_task = BashOperator(
70 | task_id="bash_task",
71 | bash_command='echo "here is the message: \\'$message\\'"',
72 | env={'message': '{{ dag_run.conf["message"] if dag_run else "" }}'},
==================================================
Hmmmm, I wonder what is going on between sphinx and pygmentize:
works fine and doesn't error. |
(I tried with |
kaxil
reviewed
Jun 5, 2020
kaxil
approved these changes
Jun 5, 2020
ashb
added a commit
that referenced
this pull request
Jun 8, 2020
(cherry picked from commit 4d8599e)
kaxil
pushed a commit
that referenced
this pull request
Jul 1, 2020
(cherry picked from commit 4d8599e)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
(cherry picked from commit 4d8599e)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.