Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: use APISIX 2.4 to run backend E2E test #1638

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Conversation

nic-chen
Copy link
Member

Please answer these questions before submitting a pull request

  • Why submit this pull request?
  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

Bugfix

  • Description

APISIX has remove consumer.id, see:
apache/apisix#3868

This is an incompatible modification, causing some of the current E2E test cases to fail

  • How to fix?

use APISIX 2.4 to run backend E2E test

@codecov-io
Copy link

codecov-io commented Mar 21, 2021

Codecov Report

Merging #1638 (f2323b3) into master (d7c0067) will decrease coverage by 1.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1638      +/-   ##
==========================================
- Coverage   72.18%   71.18%   -1.01%     
==========================================
  Files         134       47      -87     
  Lines        5645     3116    -2529     
  Branches      651        0     -651     
==========================================
- Hits         4075     2218    -1857     
+ Misses       1327      654     -673     
- Partials      243      244       +1     
Flag Coverage Δ
backend-e2e-test 61.90% <ø> (+0.19%) ⬆️
backend-e2e-test-ginkgo 47.97% <ø> (+0.25%) ⬆️
backend-unit-test 51.81% <ø> (ø)
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/store/store.go 87.95% <0.00%> (ø)
web/src/components/PluginOrchestration/index.tsx
web/src/pages/SSL/components/Step2/index.tsx
web/src/components/Footer/index.tsx
web/src/pages/Plugin/List.tsx
web/src/pages/Consumer/service.ts
...c/pages/Route/components/ResultView/ResultView.tsx
web/src/components/LabelsfDrawer/LabelsDrawer.tsx
web/src/pages/Upstream/service.ts
web/src/pages/Route/components/Step2/index.tsx
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7c0067...f2323b3. Read the comment docs.

@LiteSun LiteSun merged commit 29e9487 into apache:master Mar 22, 2021
@liuxiran liuxiran mentioned this pull request Mar 22, 2021
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants