Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bug: http_logger missing parameter keepalive #2276

Closed
Yiyiyimu opened this issue Sep 22, 2020 · 2 comments
Closed

bug: http_logger missing parameter keepalive #2276

Yiyiyimu opened this issue Sep 22, 2020 · 2 comments

Comments

@Yiyiyimu
Copy link
Member

Issue description

http_logger use keepalive but didn't set it in the schema

local schema = {
type = "object",
properties = {
uri = {type = "string"},
auth_header = {type = "string", default = ""},
timeout = {type = "integer", minimum = 1, default = 3},
name = {type = "string", default = "http logger"},
max_retry_count = {type = "integer", minimum = 0, default = 0},
retry_delay = {type = "integer", minimum = 0, default = 1},
buffer_duration = {type = "integer", minimum = 1, default = 60},
inactive_timeout = {type = "integer", minimum = 1, default = 5},
batch_max_size = {type = "integer", minimum = 1, default = 1000},
include_req_body = {type = "boolean", default = false}
},
required = {"uri"}
}

ok, err = httpc:set_keepalive(conf.keepalive)

@liuhengloveyou
Copy link
Contributor

Which branch? I can't see those codes now.

@Yiyiyimu
Copy link
Member Author

it got fixed in #2294. Thank you for your remind!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants