-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(http-logger): support for specified the log formats via admin API #2294
Conversation
why not add |
Different routes may have different log formats |
@@ -1025,7 +1025,7 @@ local function init_etcd(show_output) | |||
for _, dir_name in ipairs({"/routes", "/upstreams", "/services", | |||
"/plugins", "/consumers", "/node_status", | |||
"/ssl", "/global_rules", "/stream_routes", | |||
"/proto"}) do | |||
"/proto", "/plugin_metadata"}) do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference between metadata and the properties of plugin itself? I didn't see why we need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get plugin schema:
/apisix/admin/plugins/{plugin-name}, eg: /apisix/admin/plugins/limit-req
get plugin metadata:
/apisix/admin/plugin_metadata/{plugin-name}, eg: /apisix/admin/plugin_metadata/example-plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we need this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend using /plugins/{name}/metadata
in a RESTful way if this PR is needed..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also curious about what scenarios need metadata instead of plugin's option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR has been merged. we can talk in here: #2307 (comment)
…admin API (apache#2294)" This reverts commit 89f89f3.
What this PR does / why we need it:
as title.
For example:
when we enabled plugin
http-logger
, we will get the message body like:Pre-submission checklist: