-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[WIP] Kafka Logger. #1260
[WIP] Kafka Logger. #1260
Conversation
Hi @membphis @moonming this will be the basic kafka logger with one broker support. I think it's better to give the ability to define more brokers with object type ? broker = { And below as the schema
Also will fix the tests when schema is finalized |
LGTM |
lua/apisix/plugins/kafka-logger.lua
Outdated
local broker_list = { | ||
{ host = conf.broker_host, port = conf.port } | ||
} | ||
if #conf.broker_list == 0 then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the conf. broker_list
is a hash object, we need to use table.nkeys
to fetch the number of attributes.
#
is useful for array tables.
@@ -56,6 +56,13 @@ before_cache: | |||
- brew cleanup | |||
|
|||
before_install: | |||
- docker pull bitnami/zookeeper:3.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should install dependencies in specific scripts, eg: https://github.com/apache/incubator-apisix/blob/master/.travis/linux_openresty_runner.sh#L35
It may be a little between different os, eg: Linux and OSX.
Adding kafka plugin.
Issues resolved
Fix #1259