Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

makefile: add comments for install command. #1912

Merged
merged 3 commits into from
Jul 29, 2020
Merged

makefile: add comments for install command. #1912

merged 3 commits into from
Jul 29, 2020

Conversation

membphis
Copy link
Member

@membphis membphis commented Jul 27, 2020 •
edited
Loading

What this PR does / why we need it:

fix #1895.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

lilien1010
lilien1010 approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@lilien1010 lilien1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@membphis membphis merged commit 3947f06 into apache:master Jul 29, 2020
@membphis membphis deleted the makefile-install branch July 29, 2020 11:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lilien1010 lilien1010 lilien1010 approved these changes

@gxthrj gxthrj gxthrj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: make install did not install lua deps to apisix install dir
3 participants
@membphis @lilien1010 @gxthrj