Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

1.fix generation of uuid; #2306

Closed
wants to merge 2 commits into from
Closed

Conversation

dawn2zhang
Copy link

Change-Id: Iff73ad95f87a81bc66ecc26e9ab250a8ca41ebf6

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

zhangliming and others added 2 commits September 24, 2020 20:04
Change-Id: Iff73ad95f87a81bc66ecc26e9ab250a8ca41ebf6
@@ -107,6 +107,10 @@ function _M.http_init_worker()
require("apisix.debug").init_worker()
require("apisix.upstream").init_worker()

-- need call seed
local uuid = require("resty.jit-uuid")
uuid.seed()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/apache/apisix/blob/master/apisix/init.lua#L72

We have set the seed with a better way. So we do not need to set it agian.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in k8s, it not work very well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can print more log for confirming why it works badly. we need to know the reason.

Copy link
Member

@moonming moonming Sep 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zlm0125 ping

@membphis
Copy link
Member

membphis commented Oct 9, 2020

resolve this bug by another PR: #2357
I think we can close this PR. @zlm0125

@membphis membphis closed this Oct 13, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants