fix: fixed the non effective config update in http-logger #2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstsawyou
reviewed
Nov 30, 2020
spacewander
reviewed
Dec 1, 2020
apisix/plugins/http-logger.lua
Outdated
|
|
||
| for key, batch in ipairs(buffers) do | ||
| if #batch.entry_buffer.entries == 0 and #batch.batch_to_process == 0 then | ||
| core.log.debug("removing batch processor stale object, route id:", tostring(key)) |
There was a problem hiding this comment.
Better to use a high level log so that we can notice user. What about using warn?
There was a problem hiding this comment.
OK, this logic was copied from other x-logger.lua, i'd like to fix all of them in another PR.
There was a problem hiding this comment.
@spacewander Fixed it in http-logger firstly.
spacewander
approved these changes
Dec 1, 2020
membphis
approved these changes
Dec 1, 2020
|
@tokers you should fork APISIX repository and checkout new branch for developing, this is the right way.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Pre-submission checklist:
Close #2870