Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: load balance by least connections #3304

Merged
merged 1 commit into from
Jan 18, 2021
Merged

feat: load balance by least connections #3304

merged 1 commit into from
Jan 18, 2021

Conversation

spacewander
Copy link
Member

Fix #3086

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
feat: load balance by least connections
d16ecb8 
Fix apache#3086

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review January 15, 2021 09:58
@sysulq
Copy link
Contributor

sysulq commented Jan 15, 2021

What about p2c with least loaded, maybe we could benchmark this two implementations?

@spacewander
Copy link
Member Author

Yes, we can add a new option to enable p2c.

lilien1010
lilien1010 approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@lilien1010 lilien1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
awesome feature

@spacewander spacewander merged commit f349cc0 into apache:master Jan 18, 2021
@spacewander spacewander deleted the least_conn branch January 18, 2021 02:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lilien1010 lilien1010 lilien1010 approved these changes

@tokers tokers tokers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request help: Support load balance by least connections
4 participants
@spacewander @sysulq @lilien1010 @tokers