feat: support to communicate with etcd by TLS in command line #3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
membphis
reviewed
Jan 25, 2021
spacewander
reviewed
Jan 27, 2021
spacewander
reviewed
Jan 28, 2021
spacewander
reviewed
Jan 29, 2021
spacewander
approved these changes
Jan 29, 2021
tokers
force-pushed
the
feat/support-etcd-tls-in-cli
branch
from
2c42309 to
a956ba5
Compare
membphis
reviewed
Jan 29, 2021
| else | ||
| @echo "WARN: You're not using LuaRocks 3.x, please add the following items to your LuaRocks config file:" |
moonming
reviewed
Feb 1, 2021
| @@ -194,6 +194,13 @@ tengine_install() { | |||
| cp -r ${OPENRESTY_PREFIX}/* build-cache${OPENRESTY_PREFIX} | |||
| ls build-cache${OPENRESTY_PREFIX} | |||
| rm -rf openresty-${OPENRESTY_VERSION} | |||
|
|
|||
There was a problem hiding this comment.
do we still support tengine now?
| @@ -16,11 +16,19 @@ | |||
| # limitations under the License. | |||
| # | |||
|
|
|||
There was a problem hiding this comment.
are we not support luarocks 2.x?
There was a problem hiding this comment.
I think LuaRocks 3.x is better to use?
There was a problem hiding this comment.
agreed. So Apache APISIX not support luarocks 2.x, right?
tokers
force-pushed
the
feat/support-etcd-tls-in-cli
branch
from
a956ba5 to
18f2a19
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR implements the SSL handshaking to etcd cluster in the APISIX command line tool, and it will obey the TLS configuration in
config.yaml.Pre-submission checklist: