Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

change(prometheus): redesign the latency metrics & update grafana #3993

Merged
merged 7 commits into from
Apr 7, 2021
Merged

change(prometheus): redesign the latency metrics & update grafana #3993

merged 7 commits into from
Apr 7, 2021

Conversation

Yiyiyimu
Copy link
Member

@Yiyiyimu Yiyiyimu commented Apr 6, 2021 •
edited
Loading

Signed-off-by: yiyiyimu wosoyoung@gmail.com

What this PR does / why we need it:

Update point:

  1. Prometheus metric: add upstream latency, rename latency -> request latency, overhead -> apisix latency
  2. Grafana: move legend to the right with sort on total
  3. Grafana: split status code
  4. Grafana: delete batch process metric since it's optional

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@Yiyiyimu Yiyiyimu marked this pull request as draft April 6, 2021 09:00
@Yiyiyimu
Copy link
Member Author

Yiyiyimu commented Apr 6, 2021 •
edited
Loading

Waiting to update new screenshots

Updated

@Yiyiyimu Yiyiyimu marked this pull request as ready for review April 6, 2021 13:46
@Yiyiyimu Yiyiyimu requested review from membphis and nic-chen April 6, 2021 13:47
@Yiyiyimu
Copy link
Member Author

Yiyiyimu commented Apr 6, 2021

To make it clear, put the updated images here
1-nginx
2-bandwidth
3-http
4-Misc

@Yiyiyimu
update dashboard screenshot to current version
ac40d3f 
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
@Yiyiyimu Yiyiyimu mentioned this pull request Apr 6, 2021
Merged
4 tasks
@Yiyiyimu
fix typo
f498e46 
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
@spacewander spacewander changed the title fix: update prometheus to also expose upstream latency & update grafana change(prometheus): redesign the latency metrics & update grafana Apr 7, 2021
@Yiyiyimu
fix doc grammar
a3aa73d 
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
@spacewander spacewander merged commit b273ae7 into apache:master Apr 7, 2021
@Yiyiyimu Yiyiyimu mentioned this pull request May 14, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@spacewander spacewander spacewander approved these changes

@moonming moonming moonming approved these changes

@membphis membphis Awaiting requested review from membphis

@nic-chen nic-chen Awaiting requested review from nic-chen

@starsz starsz Awaiting requested review from starsz

@tokers tokers Awaiting requested review from tokers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yiyiyimu @spacewander @moonming @johzchen