Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: patch tcp.sock.connect to use our DNS resolver #4114

Merged
merged 3 commits into from
May 4, 2021
Merged

feat: patch tcp.sock.connect to use our DNS resolver #4114

merged 3 commits into from
May 4, 2021

Conversation

spacewander
Copy link
Member

Fix #3719

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander spacewander force-pushed the pcr branch 2 times, most recently from 748cedf to b5e77ba Compare April 23, 2021 07:08
@spacewander
feat: patch tcp.sock.connect to use our DNS resolver
22ef698 
Fix apache#3719

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review April 23, 2021 08:15
tokers
tokers reviewed Apr 23, 2021
View reviewed changes
@spacewander @tokers
Update apisix/core/resolver.lua
37cf380 
Co-authored-by: Alex Zhang <tokers@apache.org>
@spacewander
fix test
dab0008 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
membphis
membphis approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@spacewander spacewander merged commit f914807 into apache:master May 4, 2021
@spacewander spacewander deleted the pcr branch May 4, 2021 05:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@membphis membphis membphis approved these changes

@tokers tokers tokers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@spacewander @membphis @tokers