Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: make A/B test APISIX easier by removing "additionalProperties = false" #4797

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

spacewander
Copy link
Member

@spacewander spacewander commented Aug 11, 2021

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

… false"

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review August 11, 2021 04:11
@nic-chen
Copy link
Member

nic-chen commented Aug 11, 2021

wow, this change @membphis should better know, I remember he always insisted that it should be retained.

@spacewander
Copy link
Member Author

Yes. I have talked with @membphis about this.

@nic-chen
Copy link
Member

Yes. I have talked with @membphis about this.

got it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants