feat(gzip): support special * to match any type #4817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
reviewed
Aug 13, 2021
apisix/plugins/gzip.lua
Outdated
| }, | ||
| }, | ||
| { | ||
| type = "string", |
There was a problem hiding this comment.
I think enum = {"*"} is enough?
There was a problem hiding this comment.
@spacewander Yes, I think it's simpler to use {"*"}, this pr only try to follow nginx's config strictly.
If that not import, I will change it to {"*"}
There was a problem hiding this comment.
misunderstood you firstly, now i got it.
t/plugin/gzip.t
Outdated
| @@ -436,6 +436,53 @@ POST /echo | |||
| 012345678 | |||
| --- more_headers | |||
| Accept-Encoding: gzip | |||
| Content-Type: text/html | |||
There was a problem hiding this comment.
Better to use a special type to verify that any type can be matched.
RocFang
changed the title
spacewander
approved these changes
Aug 13, 2021
shuaijinchao
approved these changes
Aug 15, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
right now, type of types attr is array, and we dont't have a method to support the special
gzip_types *config in Nginx Core. So maybe we can change type of types to support single string, and support * too.Pre-submission checklist: