Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(kafka-logger): add required_acks option #4878

Merged
merged 11 commits into from
Aug 25, 2021
Merged

feat(kafka-logger): add required_acks option #4878

merged 11 commits into from
Aug 25, 2021

Conversation

okaybase
Copy link
Member

@okaybase okaybase commented Aug 23, 2021 •
edited
Loading

What this PR does / why we need it:

add required_acks option

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@okaybase okaybase requested review from tokers and nic-chen August 24, 2021 06:37
@spacewander spacewander merged commit 8c793ed into apache:master Aug 25, 2021
@okaybase okaybase deleted the feat-k branch August 25, 2021 09:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@spacewander spacewander spacewander approved these changes

@tokers tokers tokers approved these changes

@nic-chen nic-chen nic-chen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@okaybase @spacewander @tokers @nic-chen